Add detection of CODEOWNERS paths that are missing suffix slash; add support for diffing to CODEOWNERS version with some paths removed; add tools for analyzing azure-sdk-for-python CODEOWNERS.#5245
Merged
konrad-jamrozik merged 3 commits intomainfrom Jan 27, 2023
Conversation
added 3 commits
January 26, 2023 15:28
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
changed the title
CODEOWNERS paths that are missing suffix slash; add support for diffing to CODEOWNERS version with some paths removed; add tools for analyzing azure-sdk-for-python CODEOWNERS; CODEOWNERS paths that are missing suffix slash; add support for diffing to CODEOWNERS version with some paths removed; add tools for analyzing azure-sdk-for-python CODEOWNERS.
weshaggard
reviewed
Jan 27, 2023
...code-owners-parser/Azure.Sdk.Tools.RetrieveCodeOwners.Tests/CodeownersManualAnalysisTests.cs
Show resolved
Hide resolved
weshaggard
approved these changes
Jan 27, 2023
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
One question but otherwise looks fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR context
This PR is done in preparation to enable the new regex-based wildcard-supporting
CODEOWNERSmatcher forazure-sdk-for-pythonlanguage repository.It is a continuation of work done by this PR:
This PR provides information required to make a PR analogous to this one, but for
azure-sdk-for-pythonrepo:This PR is a prerequisite to enabling the new matcher on
azure-sdk-for-python, in similar way as this PR does:azure-sdk-for-netrepo #5241Thus, overall, this PR contributes to:
Changes made
CODEOWNERSpaths that are missing suffix slash, i.e. paths that would match a directory in the repository if they would have the suffix/. Because they don't, and the directory exists, such paths currently won't ever match anything.CODEOWNERSowners to its equivalent with some paths removed. This is used to determine how build failure notification recipients will change when/**/ci.ymland/**/tests.ymlpaths are removed, similarly as it was done here:/**/ci.ymland/**/tests.ymlazure-sdk-for-net#33595CODEOWNERSinformation forazure-sdk-for-python: both paths that are missing suffix slashes, as well as expected changes to build failure notification recipients when/**/ci.ymland/**/tests.ymlpaths are removed.